[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] lxc_container: Don't dereference NULL upon failure (x2)



On Wed, Feb 04, 2009 at 06:49:23PM +0100, Jim Meyering wrote:
> Spotted these while skimming through all VIR_FREE uses.
> 
> >From af9e606d97e8321683ba765ba0a4af4c065d3b4b Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering redhat com>
> Date: Wed, 4 Feb 2009 18:44:34 +0100
> Subject: [PATCH] lxc_container: Don't dereference NULL upon failure
> 
> * src/lxc_container.c (lxcContainerPivotRoot): Free and zero
> oldroot *after* printing the diagnostic, both for virFileMakePath
> and pivot_root failure.

ACK

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]