[libvirt] [PATCH] Solaris PV is localtime. Allow this setting through the conversions

[Daniel P. Berrange]

On Thu, Feb 05, 2009 at 04:12:39AM +0000, John Levon wrote:
> On Thu, Jan 29, 2009 at 11:33:10AM +0000, Daniel P. Berrange wrote:
> 
> > Hmm, current XenD may not mind having 'localtime' here, but I'm
> > worried older XenD may not be so forgiving. Will have to check
> > older source.
> 
> Any success?

After much debugging & code inspection, it looks like we need to 
explicitly set the 'localtime' config both in the top level of the
SEXPR *and* within the image/hvm part of it, in order to cope with
all versions of Xen. Some require it in the latter only, some require
it in the former only, others are a mix of both depending on PV vs
HVM guests, and some are just broken.

> > Existing code unconditionally sets localtime=0 and localtime=1,
> > but this only sets localtime=1, relying on XM defaults for localtime=0.
> > I prefer not to rely on defaults when writing the config back out to disk
> > because those have a habit of being broken over time. Unconditionally
> > setting it avoids the need to change all those test case config files.
> 
> I'm still hoping for an answer from you here too. I can make it be
> inconsistent if you like. I'm more concerned about getting the notion of
> PV localtime into the tree.

I'd like to see the config always set an explicit value, so we guarentee
that both XM and libvirt pass the same value to XenD. For completeness
we should always set it in the SEXPR too, even though we only currently
set it when localtime is enabled.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|