[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Allow off-line removal of devices via xend



Guido Günther wrote:
On Mon, Feb 09, 2009 at 11:30:30AM -0500, Cole Robinson wrote:
[..snip..]
No fault of this patch, but this makes me ask the question: what exactly
are attachDevice and detachDevice supposed to do?

In the qemu driver, it is entirely hotplug/hotunplug, and deliberately
fails on an inactive domain. This patch seems to add offline support
We don't even persist the devices being hot{added,removed} into the
domain xml so acting on inactive domains has no meaning or am I missing
something?

When the domain is enabled, and you store it... you basically get that behavior.


Stefan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]