[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix daemon TCP listen cleanup



Cole Robinson <crobinso redhat com> wrote:
> Just looking through the code, I stumbled on a bug in a cleanup routine
> in the daemon. Patch attached.
>
> Thanks,
> Cole
>
> diff --git a/qemud/qemud.c b/qemud/qemud.c
> index 6cbba21..6df6368 100644
> --- a/qemud/qemud.c
> +++ b/qemud/qemud.c
> @@ -713,7 +713,7 @@ remoteListenTCP (struct qemud_server *server,
>
>  cleanup:
>      for (i = 0; i < nfds; ++i)
> -        close(fds[0]);
> +        close(fds[i]);

Good catch.
ACK


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]