[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] fix problem with MKDIR_P vs mkdir_p



On Sun, Feb 15, 2009 at 11:37:12AM +0000, Daniel P. Berrange wrote:
> On Sat, Feb 14, 2009 at 03:03:34PM +0100, Maximilian Wilhelm wrote:
> > Anno domini 2009 Jim Meyering scripsit:
> > 
> > > Maximilian Wilhelm <max rfc2324 org> wrote:
> > > > configure defines mkdir_p but src/Makefile.am uses MKDIR_P
> > > > ---
> > > >  src/Makefile.am |    2 ++
> > > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > >
> > > > diff --git a/src/Makefile.am b/src/Makefile.am
> > > > index 9d934b4..eff9039 100644
> > > > --- a/src/Makefile.am
> > > > +++ b/src/Makefile.am
> > > > @@ -589,6 +589,8 @@ endif
> > > >  endif
> > > >  EXTRA_DIST += $(LXC_CONTROLLER_SOURCES)
> > > >
> > > > +MKDIR_P = $(mkdir_p)
> > > > +
> > > >  install-exec-local:
> > > >  	$(MKDIR_P) "$(DESTDIR)$(localstatedir)/cache/libvirt"
> > > >  	$(MKDIR_P) "$(DESTDIR)$(localstatedir)/lib/libvirt/images"
> > 
> > > This is just a symptom of your using a version of automake that is too old.
> > 
> > Oh thanks for the hint. We had to downgrade autoake to 1.9 for building
> > software for other systems... The usual auto*-fun.
> 
> That should still be OK. Libvirt is intended to use automake 1.9.x and
> autoconf autoconf 2.59  or later. Specifically the versions from 
> RHEL-5 or newer

I've verified that this patch is *not* neccessary with automake 1.9.6 
that is in RHEL-5


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]