[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix daemon TCP listen cleanup



On Mon, Feb 16, 2009 at 06:42:34PM -0500, Cole Robinson wrote:
> Just looking through the code, I stumbled on a bug in a cleanup routine
> in the daemon. Patch attached.

ACK


> diff --git a/qemud/qemud.c b/qemud/qemud.c
> index 6cbba21..6df6368 100644
> --- a/qemud/qemud.c
> +++ b/qemud/qemud.c
> @@ -713,7 +713,7 @@ remoteListenTCP (struct qemud_server *server,
>  
>  cleanup:
>      for (i = 0; i < nfds; ++i)
> -        close(fds[0]);
> +        close(fds[i]);
>      return -1;
>  }
>  


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]