[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] Implement node device assignment in QEMU driver



On Tue, Feb 24, 2009 at 10:35:39PM +0000, Mark McLoughlin wrote:
> Handle a hostdev source specified as a node device name
> by looking up the node device, parsing its XML for
> PCI/USB address details, using those as the hostdev
> source and, finally, dettaching and resetting the
> device.

I don't think we should be calling back out to the public API from
internal impl here.  If the XML just uses the PCI address directly
then we can easily call the internal pciDettach() and pciReAttach()
APIs directly, and avoid the potential for thread deadlock that
calling back out to public API could lead to.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]