[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files



"Daniel P. Berrange" <berrange redhat com> wrote:
> On Tue, Dec 23, 2008 at 06:31:14PM +0100, Jim Meyering wrote:
>> John Levon <john levon sun com> wrote:
>> > On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote:
>> >
>> >> This all looks fine, but I'd prefer to retain the WARNING in the generated
>> >> file, so that people are less likely to modify it directly.  Along the
>> >
>> > Sure, your changes sound fine - are you going to commit your version?
>>
>> I had trouble applying the first change set, both in configure.in
>> (rejected hunk) and with the renamed file.  Plus I made some small
>> additional changes, so please check it carefully.  The other 4 applied
>> cleanly.  Also, look over the five log messages.  Each of those will be
>> copied mechanically into the ChangeLog file.
>>
>> Once you sign off, I'll commit these.
>
> ACK to this.

Thanks.
All committed.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]