[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 7/25: Minor windows fix to remote driver

Minor problem in the remote driver when lacking support for
virExec(), we report an error and then carry on executing
anyway. Of course we get a EINVAL error later when we try to
write() on a FD of -1. Trivial fix

 remote_internal.c |    1 +
 1 file changed, 1 insertion(+)


diff --git a/src/remote_internal.c b/src/remote_internal.c
--- a/src/remote_internal.c
+++ b/src/remote_internal.c
@@ -690,6 +690,7 @@ doRemoteOpen (virConnectPtr conn,
     case trans_ext:
         error (conn, VIR_ERR_INVALID_ARG,
                _("transport methods unix, ssh and ext are not supported under Windows"));
+        goto failed;
 #endif /* WIN32 */

|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]