[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 16/25: Fix GNULIB warnings on Mingw



On Tue, Jan 13, 2009 at 05:45:14PM +0000, Daniel P. Berrange wrote:
> The GNULIB Makefile.am doesn't set any particular compiler warning
> flags in the belief that upstream GNULIB developers sort out all
> warnings before committing their code. This is reasonable for builds
> on mainstream Linux platforms, but MinGW builds of GNULIB don't
> have nearly the same level of testing. So This patch adds the libvirt
> $(WARN_CFLAGS) to the gnulib Makefile.am and then fixes the problems
> this showed up. Nothing of consequence really. Leave it upto gnulib
> developers whether its worth fixing these.
> 
>  Makefile.am    |    2 
>  gettimeofday.c |    5 +-
>  ioctl.c        |    1 
>  poll.c         |    4 -
>  strerror.c     |  128 ++++++++++++++++++++++++++++-----------------------------

I can't really comment, but it seems OK.  Should we CC this patch to
the bug-gnulib mailing list?

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]