[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 10/25: Remove use of strerror()



On Tue, Jan 20, 2009 at 12:46:11PM +0000, Daniel P. Berrange wrote:
> On Mon, Jan 19, 2009 at 11:40:56AM +0100, Jim Meyering wrote:
> > > diff --git a/src/test.c b/src/test.c
> > ...
> > > @@ -336,7 +339,7 @@ static int testOpenFromFile(virConnectPt
> > >      virDomainObjPtr dom;
> > >      testConnPtr privconn;
> > >      if (VIR_ALLOC(privconn) < 0) {
> > > -        testError(NULL, VIR_ERR_NO_MEMORY, "testConn");
> > > +        virReportOOMError(conn);
> > 
> > I don't remember the rules for NULL vs non-NULL conn.
> > Is this s/NULL/conn/ transform valid?
> > I think there's one more like it.
> 
> Here is an update with the fixes you mention in this mail, and 
> re-diffed based on latest CVS.

Opps, i sent the wrong version of this new patch - which is probably
why Jim saw a re-introduced use of strerror(). The correct patch
which I'll apply is the same as this but with that sterrror removed
of course :-)


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]