[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix openlog() ident usage



On Tue, Jan 20, 2009 at 10:18:31PM +0100, Daniel Veillard wrote:
> On Tue, Jan 20, 2009 at 08:36:27PM +0100, Daniel Veillard wrote:
> > On Tue, Jan 20, 2009 at 11:14:03AM -0800, john levon sun com wrote:
> > > It cannot be freed, as it's used by reference in the syslog code, at
> > > least on Solaris.
> > 
> >   The requirement is apparently not present on Linux, sorry :-)
> > 
> >   I would prefer to keep the reference around and not leak it for
> > example on reloads
> 
>   Another version with an extra strdup but making clearer what
> the change do and fixing the closelog/free order,
> 
>  if tested positively please apply, thanks !

ACK, I like this version 

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]