[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix virsh sched-credit for xend



On Mon, Jan 26, 2009 at 11:29:01AM +0000, Daniel P. Berrange wrote:

> It isn't that simple. Tunables are not represented as part of the XML,

Good point, that would need to be fixed. I'd missed this.

> So if we want to be able to set tunables on inactive domains, the 
> virDomainSetSchedularParams() is not the right place todo it - we
> can only guarentee that is is reliably usable on live domains. 

No, surely we should fix the XML to represent it, and then it /would/
work. Must be better than another identical API.

(BTW I find that the API providing a bunch of unknown name/value pairs
with no indication of what they might be a little icky...)

regards
john


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]