[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Fix misuse of PF_UNIX



# HG changeset patch
# User john levon sun com
# Date 1233105335 28800
# Node ID b3a2537e2f3d5ccb055df1820c112b469a26efdb
# Parent  35f5d4f77a3f50cadacf32100fdbd992394f6002
Fix misuse of PF_UNIX

PF_UNIX is a protocol familay, not a valid protocol, so isn't suitable
for the 3rd socket() argument. Solaris should be ignoring the invalid
protocol anyway, but this fix is correct regardless.

Signed-off-by: John Levon <john levon sun com>

diff --git a/src/xend_internal.c b/src/xend_internal.c
--- a/src/xend_internal.c
+++ b/src/xend_internal.c
@@ -752,7 +752,11 @@ xenDaemonOpen_unix(virConnectPtr conn, c
 
     memset(&priv->addr, 0, sizeof(priv->addr));
     priv->addrfamily = AF_UNIX;
-    priv->addrprotocol = PF_UNIX;
+    /*
+     * This must be zero on Solaris at least for AF_UNIX (which should
+     * really be PF_UNIX, but doesn't matter).
+     */
+    priv->addrprotocol = 0;
     priv->addrlen = sizeof(struct sockaddr_un);
 
     addr = (struct sockaddr_un *)&priv->addr;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]