[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/8] Makefile.maint: sync from coreutils

"Daniel P. Berrange" <berrange redhat com> wrote:
> If you're taking feature requests, one thing I'd like for the syntax-check

;-)  Always.

> target is for it to print out the name of each check it is running. We've
> got quite alot of checks and so it just sits there for a long time using
> 100% cpu and with no feedback as to what its doing.

Good idea.
Doing that, at first I thought I'd have to generate a makefile snippet
and "-include" it, but finally realized there is a cleaner way:

I've just done the following to coreutils, so it'll be pulled in soon,
with the next sync:

>From 44421c22a3c9aca7b7899b9fa8037d89dddaff20 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering redhat com>
Date: Thu, 29 Jan 2009 10:46:39 +0100
Subject: [PATCH] maint: teach "make syntax-check" to print each check name as it's run

* maint.mk (%.m): New rules to print each syntax-checking rule name,
just before running its commands.
($(syntax-check-rules)): Depend on it.
 maint.mk |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/maint.mk b/maint.mk
index 38724c2..65cdf5b 100644
--- a/maint.mk
+++ b/maint.mk
@@ -76,6 +76,11 @@ local-checks-available = \
   makefile-check check-AUTHORS
 .PHONY: $(local-checks-available)

+# Arrange to print the name of each syntax-checking rule just before running it.
+$(syntax-check-rules): %: %.m
+$(patsubst %, %.m, $(syntax-check-rules)):
+	@echo $(patsubst sc_%.m, %, $@)
 local-check := $(filter-out $(local-checks-to-skip), $(local-checks-available))

 syntax-check: $(local-check)

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]