[libvirt] patch: allow disk cache mode to be specified in a domain's xml definition.
Daniel P. Berrange
berrange at redhat.com
Fri Jan 30 14:41:18 UTC 2009
On Fri, Jan 30, 2009 at 03:27:55PM +0100, Jim Meyering wrote:
> "Daniel P. Berrange" <berrange at redhat.com> wrote:
> ...
> > Further up in this code its already adding cache=off for shared disks.
>
> Probably introduced by me in the merge.
>
> > There's also quite a few code style issues, not following conventions
> > of the surrounding code.
> >
> > Here's a patch which addresses all that, and more importantly adds test
> > cases covering all the cache variants QEMU has.
> >
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-none.args | 1
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-none.xml | 29 +++++++
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wb.args | 1
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wb.xml | 29 +++++++
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wt.args | 1
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wt.xml | 29 +++++++
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-none.args | 1
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-none.xml | 29 +++++++
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wb.args | 1
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wb.xml | 29 +++++++
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wt.args | 1
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wt.xml | 29 +++++++
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.args | 1
> > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml | 30 +++++++
>
> I looked through the incremental changes, and they look ok,
> but see that they do introduce new test failures:
Oh of course - I'll add this new parameter to the RNG schema - nice
to see this test doing its job & preventing us adding new XML without
corresponding schema updates :-)
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list