[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] failed test on Fedora 8



On Fri, Jan 30, 2009 at 11:06:48PM +0100, Jim Meyering wrote:
> 
> But as John Levon pointed out, there are many more tests/*test.c
> programs that use virtTestLoadFile in exactly the same way:
> 
>     $ git grep -h 'if (virtTestLoadFile'
>         if (virtTestLoadFile(outputfile, &expect, MAX_FILE) < 0)
>         if (virtTestLoadFile(cmd, &expectargv, MAX_FILE) < 0) {
>         if (virtTestLoadFile(xml, &xmlPtr, MAX_FILE) < 0)
>       if (virtTestLoadFile(xml, &xmlPtr, MAX_FILE) < 0)
>       if (virtTestLoadFile(sexpr, &sexprPtr, MAX_FILE) < 0)
>       if (virtTestLoadFile(expect, &expectPtr, MAX_FILE) < 0)
>       if (virtTestLoadFile(xml, &expectxml, MAX_FILE) < 0)
>         if (virtTestLoadFile(xml, &xmlPtr, MAX_FILE) < 0)
>         if (virtTestLoadFile(xmcfg, &xmcfgPtr, MAX_FILE) < 0)
>         if (virtTestLoadFile(xml, &xmlPtr, MAX_FILE) < 0)
>         if (virtTestLoadFile(xmcfg, &xmcfgPtr, MAX_FILE) < 0)
>       if (virtTestLoadFile(xml, &xmlPtr, MAX_FILE) < 0)
>       if (virtTestLoadFile(sexpr, &sexprPtr, MAX_FILE) < 0)
> 
> So rather than applying the same multi-line fix to all of those uses,
> I expect to revert that patch and move the error reporting
> into virtTestLoadFile itself.

Seems like a sensible idea to me.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]