[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Fix node dumpxml infinite loop



With current git, doing:

'virsh nodedev-dumpxml computer'

locks up the daemon. The list iteration in update_caps was only happening
conditionally: if that condition wasn't met, we loop forever.

- Cole
diff --git a/src/node_device.c b/src/node_device.c
index cd9f0ef..e0aaefc 100644
--- a/src/node_device.c
+++ b/src/node_device.c
@@ -73,8 +73,8 @@ static int update_caps(virNodeDeviceObjPtr dev)
                               cap->data.scsi_host.host);
                 }
             }
-            cap = cap->next;
         }
+        cap = cap->next;
     }
 
     return 0;

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]