[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] provide the object name on lookup error



On Tue, Jul 07, 2009 at 05:50:58PM +0100, Daniel P. Berrange wrote:
> On Tue, Jul 07, 2009 at 05:52:03PM +0200, Daniel Veillard wrote:
> >   There were a number of places where the object name was not not
> > reported, based on the use I don't think the string could be NULL
> > in any of those. I also fixed a few POOL error which were really
> > VOLume ones.
> 
> There's a few places here still using VIR_ERR_INVALID_xxxxx which
> could also be changed to VIR_ERR_NO_xxxx, since the INVALID errors
> codes description is refering to bad pointer addresses.
> 
> Aside from that, this looks good.

  Ah, right ! I fixed those too when in scope of the patch,

   applied and commited,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]