[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Don't use mylibtool, (subsumed by automake's silent rules)



Jim Meyering wrote:
> Daniel P. Berrange wrote:
>> On Wed, Jul 08, 2009 at 11:51:59AM +0200, Jim Meyering wrote:
>>> Its use was causing a non-srcdir build to fail.
>>> * Makefile.am (EXTRA_DIST): Remove mylibtool.
>>> * configure.in: Don't use mylibtool.
>>> ---
>>>
>>> An alternative (if you don't want to use automake's silent-rules option)
>>> would be to keep mylibtool, but to use $(abs_top_srcdir) rather than
>>> $(top_srcdir) in that script.
>>
>> NACK, this only works with automake 1.11, which is not available
>> on RHEL-5
>
> Here's that alternative patch:
>
>>From 018953765f5329c0e7ac182e5e0ce4e550528238 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering redhat com>
> Date: Wed, 8 Jul 2009 12:49:27 +0200
> Subject: [PATCH] mylibtool: fix a "make distcheck" and non-srcdir build failure
>
> * configure.in (LIBTOOL): Use $(abs_top_srcdir), not $(top_srcdir).
> ---
>  configure.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure.in b/configure.in
> index 1170958..b135987 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -60,7 +60,7 @@ AC_LIBTOOL_WIN32_DLL
>
>  AM_PROG_LIBTOOL
>  dnl Override normal libtool in favour of our quiet version
> -LIBTOOL='$(SHELL) $(top_srcdir)/mylibtool'
> +LIBTOOL='$(SHELL) $(abs_top_srcdir)/mylibtool'

This is wrong, since it's libtool that is in the builddir.
New patch after lunch.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]