[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] fix two "make syntax-check" failures



On Thu, Jul 09, 2009 at 08:09:05PM +0200, Jim Meyering wrote:
> Mark McLoughlin pointed out this failure:
> 
>     ChangeLog-old: if (foo) free (foo)
>     ChangeLog-old: if (foo != NULL) free (foo)
>     maint.mk: found useless "if" before "free" above
>     make: *** [sc_avoid_if_before_free] Error 1

  Heh, :-)

> Here's the other:
> 
> --- po/POTFILES.in
> +++ po/POTFILES.in
> @@ -1,3 +1,4 @@
> +cfg.mk
>  qemud/qemud.c
>  qemud/remote.c
>  src/bridge.c
> maint.mk: you have changed the set of files with translatable diagnostics;
>  apply the above patch
> 
> I had fixed the latter in gnulib (now that main.mk comes
> from there), but had forgotten to tell libvirt to use
> the latest version of gnulib, in order to get that fix.
> To do that, I ran "git syncsub" (where syncsub is an alias:
> syncsub = submodule foreach git pull origin master)
> then git commit -a.
> 
> Here are the two patches I'm about to push:

  Fine, ACK,

  thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]