[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4] Minor qemu monitor coding style fixes



On Thu, Jul 09, 2009 at 08:09:44PM +0100, Mark McLoughlin wrote:
> * src/qemu_driver.c: use a consistent coding style for function
>   definitions
> ---
>  src/qemu_driver.c |   29 +++++++++++++++++------------
>  1 files changed, 17 insertions(+), 12 deletions(-)
> 
> diff --git a/src/qemu_driver.c b/src/qemu_driver.c
> index 636ee9d..d74596f 100644
> --- a/src/qemu_driver.c
> +++ b/src/qemu_driver.c
> @@ -820,11 +820,13 @@ qemudCheckMonitorPrompt(virConnectPtr conn ATTRIBUTE_UNUSED,
>      return 0;
>  }
>  
> -static int qemudOpenMonitor(virConnectPtr conn,
> -                            struct qemud_driver* driver,
> -                            virDomainObjPtr vm,
> -                            const char *monitor,
> -                            int reconnect) {
> +static int
> +qemudOpenMonitor(virConnectPtr conn,
> +                 struct qemud_driver* driver,
> +                 virDomainObjPtr vm,
> +                 const char *monitor,
> +                 int reconnect)
> +{
>      int monfd;
>      char buf[1024];
>      int ret = -1;
> @@ -878,10 +880,12 @@ static int qemudOpenMonitor(virConnectPtr conn,
>  }
>  
>  /* Returns -1 for error, 0 success, 1 continue reading */
> -static int qemudExtractMonitorPath(virConnectPtr conn,
> -                                   const char *haystack,
> -                                   size_t *offset,
> -                                   char **path) {
> +static int
> +qemudExtractMonitorPath(virConnectPtr conn,
> +                        const char *haystack,
> +                        size_t *offset,
> +                        char **path)
> +{
>      static const char needle[] = "char device redirected to";
>      char *tmp, *dev;
>  
> @@ -974,9 +978,10 @@ cleanup:
>      return ret;
>  }
>  
> -static int qemudWaitForMonitor(virConnectPtr conn,
> -                               struct qemud_driver* driver,
> -                               virDomainObjPtr vm, off_t pos)
> +static int
> +qemudWaitForMonitor(virConnectPtr conn,
> +                    struct qemud_driver* driver,
> +                    virDomainObjPtr vm, off_t pos)
>  {
>      char buf[4096]; /* Plenty of space to get startup greeting */
>      int logfd;

ACK


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]