[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] storage: disk: Default to 'ext2' for new volumes.



On Fri, Jul 10, 2009 at 03:32:22PM -0400, Cole Robinson wrote:
> Currently, if no format is specified for a new disk volume, we pass the
> invalid value "none" as the FS type to 'parted mkpart'.
> 
> There doesn't seem to be a way to have parted not format the drive, so
> just default to using 'ext2' in this case: this shouldn't cause any harm,
> since we are creating a new partition in the first place.
> ---
>  src/storage_conf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/storage_conf.c b/src/storage_conf.c
> index fe1dc90..075279c 100644
> --- a/src/storage_conf.c
> +++ b/src/storage_conf.c
> @@ -95,7 +95,7 @@ VIR_ENUM_IMPL(virStorageVolFormatFileSystem,
>  
>  VIR_ENUM_IMPL(virStoragePartedFsType,
>                VIR_STORAGE_PARTED_FS_TYPE_LAST,
> -              "none", "ext2", "fat16",
> +              "ext2", "ext2", "fat16",
>                "fat32", "linux-swap",
>                "ext2", "ext2",
>                "extended")

ACK


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]