[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] storage: disk: Fix parthelper '-g' option handling.



On Fri, Jul 10, 2009 at 03:32:20PM -0400, Cole Robinson wrote:
> Typo was breaking 'parthelper -g', preventing disk pool definition.
> ---
>  src/parthelper.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/parthelper.c b/src/parthelper.c
> index f456ccc..5df46e8 100644
> --- a/src/parthelper.c
> +++ b/src/parthelper.c
> @@ -36,7 +36,7 @@
>  #include <stdio.h>
>  
>  /* we don't need to include the full internal.h just for this */
> -#define STRNEQ(a,b) (strcmp((a),(b)) != 0)
> +#define STREQ(a,b) (strcmp((a),(b)) == 0)
>  
>  /* Make the comparisons below fail if your parted headers
>     are so old that they lack the definition.  */
> @@ -56,7 +56,7 @@ int main(int argc, char **argv)
>      PedPartition *part;
>      int cmd = DISK_LAYOUT;
>  
> -    if (argc ==  3 && STRNEQ(argv[2], "-g")) {
> +    if (argc == 3 && STREQ(argv[2], "-g")) {
>          cmd = DISK_GEOMETRY;
>      } else if (argc != 2) {
>          fprintf(stderr, "syntax: %s DEVICE [-g]\n", argv[0]);

  Oops, that's me :-\
  ACK

W.r.t. redefinition, well it was looking like including the full
internal.h was way beyond the scope of that small check.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]