[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Handle changed monitor syntax for PCI hotplug/unplug



On Thu, Jul 16, 2009 at 10:30:06AM +0100, Daniel P. Berrange wrote:
> On Thu, Jul 16, 2009 at 10:47:44AM +0200, Daniel Veillard wrote:
> > On Tue, Jul 07, 2009 at 05:45:58PM +0100, Daniel P. Berrange wrote:
> > > Annoyingly when PCI hotplug support was merged from KVM into QEMU the 
> > > monitor syntax changed :-(  This patch tries to deal with this by
> > > detecting the error message, and then re-trying with the alternative
> > > syntax.  
> > > 
> > > It also ensures the monitor error mesages is include with any libvirt
> > > error raised, so that we can more easily detect problems in the future
> > 
> >   Okay, patch tries the new syntax first, looks fine, ACK !
> 
> Actaully it tries the old syntax first. I should probably reverse it

  Ah right ! ... ( : ? ) construct is prone to misreading...

> to use the new syntax first, since that'll be more common

  Okay :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]