[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/9] Move queuing of RPC replies into dispatch code



On Tue, Jul 14, 2009 at 11:19:22AM +0100, Daniel P. Berrange wrote:
> This removes an assumption from qemudWorker() code that every
> incoming message will generate a reply.
[...]
> +++ b/qemud/dispatch.c
> @@ -387,6 +387,12 @@ rpc_error:

  Hmpf any way to tell git to not use labels as diff context identifiers ?
>      msg->bufferLength = len;
>      msg->bufferOffset = 0;
>  
> +    /* Put reply on end of tx queue to send out  */
> +    qemudClientMessageQueuePush(&client->tx, msg);
> +
> +    if (qemudRegisterClientEvent(server, client, 1) < 0)
> +        qemudDispatchClientFailure(client);
> +
>      return 0;
>  
>  fatal_error:

  Okay, looks fine.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]