[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/9] Storage cloning for LVM and Disk backends



Daniel Veillard wrote:
> On Fri, Jul 10, 2009 at 04:46:57PM -0400, Cole Robinson wrote:
>> This following series implements cloning for LVM and disk backends. Most
>> of the functionality is already here, it just needed some reorganization
>> to be accessible for every backend.
>>
>> I verified the following scenarios produced a bootable image:
>>
>> - Clone within a disk pool
>> - Clone within a logical pool
>> - Clone a raw file to a disk pool
>> - Clone a disk pool to a logical pool
>>
>> Cole Robinson (9):
>>   storage: Refactor FS backend 'create' function choosing.
>>   storage: Always assume we are tracking alloc progress in FS backend
>>   storage: Move most of the FS creation functions to common backend.
>>   storage: cleanup: do away with 'createFile'
>>   storage: Break out actual raw cloning to separate function.
>>   storage: Implement 'CreateBlockFrom' helper.
>>   storage: Don't try sparse detection if writing to block device.
>>   storage: Implement CreateVolFrom for logical and disk backend.
>>   storage: Fix deadlock when cloning across pools.
> 
>   Sounds good, I went through the set of patches and didn't detect
> anything, Dan's review is more thorough !
> 
>   ACK for me,
> 
>     thanks, that will improve users experience I'm sure :-)
> 

Thanks, pushed now (with patch 2 dropped).

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]