[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] Bugfix for failing to reconnect to vbox:///session

Hi All,

While reconnecting to vbox:///session, since the VBoxCGlueInit() is not 
intialized, the g_pfnGetFunctions is NULL and thus reconnection fails with 
SEGV. Fixed this in the patch below.

commit 9df6333b50a8b512b30ec5bbbfd01a2eec6cbf8b
Author: Pritesh Kothari <Pritesh Kothari Sun com>
Date:   Fri Jul 17 18:45:57 2009 +0200

    libvirt: fixed the intialization routine

diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index 74c432e..2ccfbd8 100644
--- a/src/vbox/vbox_tmpl.c
+++ b/src/vbox/vbox_tmpl.c
@@ -310,6 +310,12 @@ no_memory:
 static int vboxInitialize(virConnectPtr conn, vboxGlobalData *data) {
+    /* Intialize the Glue Library else you can't get to the g_pfnGetFunctions
+     * function which is needed to fetch the right version of driver */
+    if ((VBoxCGlueInit() < 0) || (g_pfnGetFunctions == NULL))
+        goto cleanup;
     /* Get the API table for out version, g_pVBoxFuncs is for the oldest
        version of the API that we support so we cannot use that. */
     data->pFuncs = g_pfnGetFunctions(VBOX_XPCOMC_VERSION);

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]