[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/14] Add NIC and hostnet names to domain state XML



On Mon, Jul 20, 2009 at 12:51:17PM +0100, Mark McLoughlin wrote:
> The qemu driver needs to assign and keep track of identifiers for
> network devices so that it can remove them. We need to keep this state
> across libvirtd restarts, but it's not configuration that needs to
> be kept across guest restarts.
> 
> * src/domain_conf.c: parse and format <state nic="foo" hostnet="bar"/>
> ---
>  src/domain_conf.c |   27 +++++++++++++++++++++++++--
>  1 files changed, 25 insertions(+), 2 deletions(-)

  Okay except the use of flags, an extra "int internal" parameter would
be just fine IMHO,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]