[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 11/14] Remove the network backend if NIC hotplug fails



On Mon, 2009-07-20 at 14:56 +0200, Daniel Veillard wrote:
> On Mon, Jul 20, 2009 at 12:51:21PM +0100, Mark McLoughlin wrote:
> >      if (qemudMonitorCommand(vm, cmd, &reply) < 0) {
> > -        /* FIXME: try and remove the backend again */
> >          qemudReportError(conn, dom, NULL, VIR_ERR_OPERATION_FAILED,
> >                           _("failed to add NIC with '%s'"), cmd);
> >          VIR_FREE(cmd);
> > -        return -1;
> > +        goto try_remove;
> >      }
> 
>   idem, maybe patch 10 and 11  don't need to be separated

Just trying to make things easier to review by adding stuff iteratively.

(I probably should have mentioned in 10 that the problems mentioned in
the patch description are tackled in subsequent patches)

Cheers,
Mark.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]