[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] Release conn lock before reporting errors in vir(Get|Release)Interface



On Wed, Jul 22, 2009 at 01:20:58AM -0400, Laine Stump wrote:
> Since virRaiseErrorFull needs to lock the conn, we must take care to
> call it with the lock *not* held.
> 
> If this patch is approved, similar patches need to be done for other
> types in datatypes.c

Doh, that's a annoying edge case ! ACK

If you have time to do the same change to other methods in this
file that'd be very helpful

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]