[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/9] Add support for encrypted (qcow) volume creation.



On Tue, Jul 21, 2009 at 01:12:00PM +0200, Miloslav Trma?? wrote:
> Supports only virStorageVolCreateXML, not virStorageVolCreateXMLFrom.
> 
> Curiously, qemu-img does not need the passphrase for anything to create
> an encrypted volume.  This implementation is sufficient for the qcow2
> format, and for other formats when all encryption parameters are
> pre-specified.

I believe that qemu-img only requires the passphrase if it is going
to actually write data blocks to the file. Thus creating an empty
file doesn't need it, but in the code path which clones an existing
file it would need it. eg, virStorageVolCreateXMLFrom() would need
it if you had implemented that - indeed that would potentially need 
both the source and destination keys.


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]