[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add bare %s format string to printf-derivatives called with no format string



On Thu, Jul 23, 2009 at 11:01:15AM -0400, Laine Stump wrote:
> On 07/23/2009 06:53 AM, Daniel P. Berrange wrote:
>> On Wed, Jul 22, 2009 at 04:22:22PM -0400, Laine Stump wrote:
>>    
>>> ---
>>>   src/datatypes.c       |   24 ++++++++++++------------
>>>   src/domain_conf.c     |    9 +++++----
>>>   src/interface_conf.c  |    4 ++--
>>>   src/lxc_driver.c      |    2 +-
>>>   src/qemu_driver.c     |    4 ++--
>>>   src/storage_backend.c |    6 +++---
>>>   src/virsh.c           |    4 ++--
>>>   7 files changed, 27 insertions(+), 26 deletions(-)
>>>      
>>
>> ACK to the changes, but there's a few bits of wierd whitespace in this
>>    
>
>
> Strange. It doesn't make sense for those to accidentally creep in via  
> emac's reformatting (except the virsh.c - I probably forgot to set  
> "libvirt style" on that file :-), but they also don't look like anything  
> I'd do by hand.
>
> Did you correct it, or do you want me to resubmit?

  I pushed with the needed fixes :-)

    thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]