[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Don't allow NULL paths for BlockStats and InterfaceStats



On Fri, Jul 24, 2009 at 11:05:28AM -0400, Cole Robinson wrote:
> Do the check in libvirt.c, to save drivers from the burden. This changes
> behavior slightly in the qemu driver: we no longer explictly error if
> passed an empty string. An error will still be thrown when the device
> lookup fails.

  ACK, I would just add (path[0] = 0) as one of the parameter failure
in libvirt.c directly

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]