[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] test: Implement BlockStats and InterfaceStats



On Fri, Jul 24, 2009 at 11:05:30AM -0400, Cole Robinson wrote:
> We fake stats values based on the current time, similar to how it's done
> for cpu time.

> +    if (gettimeofday(&tv, NULL) < 0) {
> +        virReportSystemError(domain->conn, errno,
> +                             "%s", _("getting time of day"));
> +        goto error;
> +    }

  can gettimeofday fail if the args are correct ? But that's fine :-)

With the second patch that looks fine.

  ACK

daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]