[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 10/14] Convert NEWS to UTF-8



On Tue, Jul 28, 2009 at 07:44:13PM +0100, Mark McLoughlin wrote:
> Added by Rich Jones for this rpmlint warning:
> 
>   libvirt.x86_64: W: file-not-utf8 /usr/share/doc/libvirt-0.6.0/NEWS
> 
> See:
> 
>   https://bugzilla.redhat.com/226055
> ---
>  libvirt.spec.in |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index dcedbe0..2645a22 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -245,6 +245,9 @@ of recent versions of Linux (and other OSes).
>  %prep
>  %setup -q
>  
> +mv NEWS NEWS.old
> +iconv -f ISO-8859-1 -t UTF-8 < NEWS.old > NEWS
> +
>  %build
>  %if ! %{with_xen}
>  %define _without_xen --without-xen
> -- 
> 1.6.2.5

  The proper fix is actually to change docs/news.xsl top level
<xsl:output method="text" encoding="ISO-8859-1"/> into
<xsl:output method="text" encoding="UTF8"/>
but that work at release time not at packaging time which is why the
change was made in the rpm (or how doing things at the distro level is
the wrong place to fix things).
  I will fix that in time for 0.7.0,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]