[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Remove MAX_TAP_ID, take 2



Daniel P. Berrange wrote:  [Wed Jul 29 2009, 12:32:08PM EDT]
> On Wed, Jul 29, 2009 at 12:27:58AM -0400, Aron Griffis wrote:
> > (Sorry, my first posting included some gnulib droppings in the
> > patch. This removes that, everything else is the same.)
> > 
> > As far as I can tell, there's no reason to format the device string in
> > brAddTap().  Delegate the job to TUNSETIFF, thereby removing the loop
> > and the MAX_TAP_ID artificial limit.  This patch allows me to get
> > 421 guests running before hitting other limits.
> 
> Very bizarre, the kernel seems to interpret 'vnet%d' and auto
> fillin the unique integer for us. So this patch is just removing
> the equivalent logic from libvirt. Wonder why we had it there in
> the first place ! So this looks basically sound to me.
> 
> Out of interest, what are the other limits you hit .. ?

$ virsh start kvm-tile26-idle9
error: Failed to start domain kvm-tile26-idle9
error: cannot create pipe: Too many open files

> This patch does not apply though - I think it has whitespace 
> damage from your mail client - neither patch, or git apply
> like it. Could you try re-sending it..

Sorry about that.  I was futzing with stgit and goofed a bit,
hence the three copies on the list.  I'll resend.

Thanks,
Aron


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]