[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Remove MAX_TAP_ID, take 3



On Wed, Jul 29, 2009 at 08:05:37PM +0200, Daniel Veillard wrote:
> On Wed, Jul 29, 2009 at 12:52:30PM -0400, Aron Griffis wrote:
> > This is a resend of take 2 to fix formatting problems in the
> > patch.  No other changes.
> > 
> > As far as I can tell, there's no reason to format the device
> > string in brAddTap().  Delegate the job to TUNSETIFF, thereby
> > removing the loop and the MAX_TAP_ID artificial limit.  This
> > patch allows me to get 421 guests running before hitting other
> > limits.
> 
>   haha ! that one worked :-)
> 
> I will review and apply, thanks !

  Actually just looking at brAddTap() after patching makes it clear,
and based on Mark and Dan feedback great !
  Applied and commited to git, thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]