[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Workaround for broken GCC in Debian Etch



On Thu, Jul 30, 2009 at 09:29:20PM +0200, Maximilian Wilhelm wrote:
> Hi again!
> 
> I missed one patch for working around a GCC bug in Debian Etch
> regarding limit definitions.
> 
> Sorry for the unstripped git-format-patch outputs, I just realised
> this after pressing send :(
> 
> (This seems to be not my day :))
> 
> Ciao
> Max
> -- 
> Gib Dein Bestes. Dann ├╝bertriff Dich selbst!

> * src/storage_backend_fs.c: Work around broken limits.h in Debian Etch.
> 
> ---
>  src/storage_backend_fs.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/src/storage_backend_fs.c b/src/storage_backend_fs.c
> index ca6d329..599cf1a 100644
> --- a/src/storage_backend_fs.c
> +++ b/src/storage_backend_fs.c
> @@ -44,6 +44,12 @@
>  #include "memory.h"
>  #include "xml.h"
>  
> +/* Work around broken limits.h on debian etch */
> +#if defined __GNUC__ && defined _GCC_LIMITS_H_ && ! defined ULLONG_MAX
> +# define ULLONG_MAX   ULONG_LONG_MAX
> +#endif

Since it is 'internal.h' that pulls in limits.h, we should probably
just put that logic in internal.h, so it is visible to all libvirt
source files, and delete the duplicate in storage_conf.c

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]