[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Regression in createQemuImg()@storage_backend_fs.c of 0.6.4



On Fri, Jun 5, 2009 at 12:40 AM, Cole Robinson<crobinso redhat com> wrote:
> Ryota Ozaki wrote:

>> I've addressed the regression with the patch
>>
>> -        if (!inputBackingPath ||
>> +        if (inputBackingPath &&
>>
>> However, I'm not sure whether this fix satisfies the aim of
>> the original code. Any idea?
>>
>
> Ahh, that's my fault. The idea is that if cloning a volume, the backing
> store from the original vol must match the backing store in the new XML.
> Thanks for looking into this. I think the correct fix is:

Oh, I see. Your patch looks good for me and my system works well
with that, so ACK!

  ozaki-r

>
> diff --git a/src/storage_backend_fs.c b/src/storage_backend_fs.c
> index be6d011..3e26fce 100644
> --- a/src/storage_backend_fs.c
> +++ b/src/storage_backend_fs.c
> @@ -1255,8 +1255,9 @@ static int createQemuImg(virConnectPtr conn,
>          * backing store, not really sure what use it serves though, and it
>          * may cause issues with lvm. Untested essentially.
>          */
> -        if (!inputBackingPath ||
> -            !STREQ(inputBackingPath, vol->backingStore.path)) {
> +        if (inputvol &&
> +            (!inputBackingPath ||
> +             !STREQ(inputBackingPath, vol->backingStore.path))) {
>             virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
>                                   "%s", _("a different backing store
> can not "
>                                           "be specified."));
>
>
> <minus the line wrapping>
>
> - Cole
>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]