[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] Add support for serial number in HAL storage



On Mon, Jun 08, 2009 at 02:18:14PM -0400, David Allan wrote:
> ---
>  src/node_device_conf.c |    5 +++++
>  src/node_device_conf.h |    1 +
>  src/node_device_hal.c  |    1 +
>  3 files changed, 7 insertions(+), 0 deletions(-)

ACK, patch looks pretty trivial & fine. Could you also extend the
docs/schemas/nodedev.rng file and add a file in tests/nodedevschemadata/
with example usage. An additive patch to this one is fine. 


Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]