[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] Add support for serial number in HAL storage



Daniel P. Berrange wrote:
On Mon, Jun 08, 2009 at 02:18:14PM -0400, David Allan wrote:
---
 src/node_device_conf.c |    5 +++++
 src/node_device_conf.h |    1 +
 src/node_device_hal.c  |    1 +
 3 files changed, 7 insertions(+), 0 deletions(-)

ACK, patch looks pretty trivial & fine. Could you also extend the
docs/schemas/nodedev.rng file and add a file in tests/nodedevschemadata/
with example usage. An additive patch to this one is fine.

I think the attached patch does both of those things.

Dave

>From b6e24f38bc31871078c98b0a734f61590c781c91 Mon Sep 17 00:00:00 2001
From: David Allan <dallan redhat com>
Date: Wed, 10 Jun 2009 16:12:36 -0400
Subject: [PATCH 1/1] Add serial to nodedev schema & tests

---
 docs/schemas/nodedev.rng                           |    5 +++++
 ...ge_serial_3600c0ff000d7a2a5d463ff4902000000.xml |   15 +++++++++++++++
 2 files changed, 20 insertions(+), 0 deletions(-)
 create mode 100644 tests/nodedevschemadata/storage_serial_3600c0ff000d7a2a5d463ff4902000000.xml

diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng
index ae6654c..78bd6a8 100644
--- a/docs/schemas/nodedev.rng
+++ b/docs/schemas/nodedev.rng
@@ -283,6 +283,11 @@
 	<text/>
       </element>
     </optional>
+    <optional>
+      <element name='serial'>
+	<text/>
+      </element>
+    </optional>
 
     <choice>
       <ref name='capstorageremoveable'/>
diff --git a/tests/nodedevschemadata/storage_serial_3600c0ff000d7a2a5d463ff4902000000.xml b/tests/nodedevschemadata/storage_serial_3600c0ff000d7a2a5d463ff4902000000.xml
new file mode 100644
index 0000000..e341f39
--- /dev/null
+++ b/tests/nodedevschemadata/storage_serial_3600c0ff000d7a2a5d463ff4902000000.xml
@@ -0,0 +1,15 @@
+<device>
+  <name>storage_serial_3600c0ff000d7a2a5d463ff4902000000</name>
+  <parent>pci_10df_fe00_scsi_host_scsi_device_lun8</parent>
+  <capability type='storage'>
+    <block>/dev/sdj</block>
+    <bus>pci</bus>
+    <drive_type>disk</drive_type>
+    <model>MSA2012fc</model>
+    <vendor>HP</vendor>
+    <serial>3600c0ff000d7a2a5d463ff4902000000</serial>
+    <size>15626928128</size>
+  </capability>
+</device>
+
+
-- 
1.6.0.6


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]