[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] [v2] Support kvm-img or qemu-img dynamically



On Wed, Jun 10, 2009 at 10:28:00AM -0500, Doug Goldstein wrote:
> This patch adds a new function virFindFileInPath() and uses it to find
> where a binary lives in the PATH environment variable. Using this, we
> can dynamically find where utility functions exist (and if they even
> exists). So such we remove the build-time check for qemu-img and make it
> dynamic for kvm-img and qemu-img. Several distros uses kvm-img over
> qemu-img when installing KVM. kvm-img also includes several patches
> which Red Hat is trying to upstream with QEMU so this patch supports
> those features which are commented out in libvirt when using kvm-img
> 
> Signed-off-by: Doug Goldstein <cardoe gentoo org>

ACK, this looks good


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]