[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] Add support for serial number in HAL storage



On Wed, Jun 10, 2009 at 04:20:08PM -0400, Dave Allan wrote:
> Daniel P. Berrange wrote:
>> On Mon, Jun 08, 2009 at 02:18:14PM -0400, David Allan wrote:
>>> ---
>>>  src/node_device_conf.c |    5 +++++
>>>  src/node_device_conf.h |    1 +
>>>  src/node_device_hal.c  |    1 +
>>>  3 files changed, 7 insertions(+), 0 deletions(-)
>>
>> ACK, patch looks pretty trivial & fine. Could you also extend the
>> docs/schemas/nodedev.rng file and add a file in tests/nodedevschemadata/
>> with example usage. An additive patch to this one is fine. 
>
> I think the attached patch does both of those things.

  Okidoc, applied both patches, the test filename is a bit long but
I don't think it's really a problem.

    thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]