[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Fix FS volume creation with backing stores.



This regressed when CreateXMLFrom was added: we should only perform the
backing store comparison if an input volume was passed.

Signed-off-by: Cole Robinson <crobinso redhat com>
---
 src/storage_backend_fs.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/storage_backend_fs.c b/src/storage_backend_fs.c
index ac7c424..5b9830e 100644
--- a/src/storage_backend_fs.c
+++ b/src/storage_backend_fs.c
@@ -1251,8 +1251,9 @@ static int createQemuImg(virConnectPtr conn,
          * backing store, not really sure what use it serves though, and it
          * may cause issues with lvm. Untested essentially.
          */
-        if (!inputBackingPath ||
-            !STREQ(inputBackingPath, vol->backingStore.path)) {
+        if (inputvol &&
+            (!inputBackingPath ||
+             !STREQ(inputBackingPath, vol->backingStore.path))) {
             virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
                                   "%s", _("a different backing store can not "
                                           "be specified."));
-- 
1.6.0.6


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]