[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Allow USB hostdev product to be 0x0000



On 06/16/2009 05:54 AM, Daniel Veillard wrote:
> On Mon, Jun 15, 2009 at 06:11:09PM -0400, Cole Robinson wrote:
>> Product = 0 is a valid value based on this bug report:
>>
>> https://www.redhat.com/archives/libvir-list/2009-May/msg00368.html
> 
>   Looks fine, ACK.
> I was wondering about the vendor ID but apparently nobody uses 0
>   http://www.linux-usb.org/usb.ids
> but maybe the same cleanup should be done for vendor ID though it looks
> far less likely unless there is some hardware defect.
> 

Committed now, with a similar cleanup for 'vendor', but only to give a less
ambiguous error if vendor = 0.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]