[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller



Cole Robinson wrote:  [Tue Jun 16 2009, 02:44:28PM EDT]
> On 06/16/2009 01:35 PM, Amy Griffis wrote:
> > The lxc controller can't see libvirtd's log level setting so it
> > needs to re-query it from the environment. The parsing code has
> > a few users now, so I added a new function to the internal API,
> > virLogParseDefaultPriority() along the lines of the other parse
> > functions.
> 
> I'd say go the extra step and add something like virLogSetFromEnv, which
> encapsulates the duplicate getenv calls as well.

I thought about that, but wanted to keep consistent behavior with
the other two parsing routines. I think we could go ahead and
change all of them to include the getenv(). Only minor gotcha is
qemud wants to call virLogParseOutputs() with it's own string in
one case. So we'd need to make the getenv() conditional on not
getting an input string. I think this would be cleaner. What do
you think?

> There is also another duplicate of this code in tests/eventtest.c.

Oops, missed that one. Thanks.

Amy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]