[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Problem compiling latest code from libvirt CVS



On Fri, Jun 05, 2009 at 01:43:15PM -0400, Dave Allan wrote:
> Daniel P. Berrange wrote:
>> On Fri, Jun 05, 2009 at 12:08:13PM -0400, Dave Allan wrote:
>>> Daniel P. Berrange wrote:
>>> <snip>
>>>> which is failing because neither of the node device driver implementations
>>>> are turned on.
>>>>
>>>> This is a bug in the storage_backend.c file. This is a generic shared file
>>>> and as such, it should not have any  dependancy on the node device 
>>>> driver code, since the latter is guarenteed to be available.
>>> I'd split out this code to avoid duplication, but I'll refactor it 
>>> again to avoid the dependency on the node device code & submit a 
>>> patch.
>>
>> Simply having the dependancy reversed should be OK. storage_backend.c
>> is a shared file always available to drivers.
>>
>> Daniel
>
> Here's a patch that should remove the dependency on the node device code.

  Oops totally forgot about it ! Applied and commited, thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]