[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add virsh commands for virInterface* functions - Take 2



On Fri, Jun 19, 2009 at 05:24:20PM +0200, Daniel Veillard wrote:
> On Fri, Jun 19, 2009 at 10:57:59AM -0400, Laine Stump wrote:
> > 
> > This is a resubmission of the virsh commands to expose virInterface*
> > functionality. I've made the following changes from the original:
> > 
> > 1) command names changed from if-* to iface-*
> > 
> > 2) "if-create" is now "iface-start"
> > 
> > 3) iface-edit implementation is manually included directly in virsh.c
> >    rather than being generated with a makefile rule.
> > 
> > 4) iface-list now has options --inactive and --all, similar to net-list.
> > 
> > (4) depends on new functions contained in the patch I submitted yesterday.
> > 
> > 
> > All of this builds and appears to be correct, but is non-functional
> > until either the netcf backend or test driver backend is
> > committed. The netcf backend is waiting on something in netcf to
> > provide the functionality required for
> > virConnectListDefinedInterfaces(), and the test driver is waiting on
> > XML parsing/formatting functions (and needs a small amount of rework
> > to support inactive interfaces).
> 
>   Looks fine to me, though IMHO we really need to clear up the XML
> format description before netcf can really be plugged. I have some
> versions of interface_conf.[ch] too but with an intermediate XML format
> so not too useful right now,
> 
>   ACK,
> 
> Daniel

Did we come to a final agreement with David yesterday on what the XML format
would look like? Seems like we were getting close at least...

--H


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]