[libvirt] [PATCH] Fix segfault if storage pool has no type attribute (possibly others)

Daniel P. Berrange berrange at redhat.com
Fri Jun 19 17:08:22 UTC 2009


On Fri, Jun 19, 2009 at 12:36:51PM -0400, Cole Robinson wrote:
> virEnumFromString doesn't check for a NULL string, and will segfault if
> passed one. Lots of calling code protects against this, but at least
> /pool/@type parsing does not.
> 
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
>  src/util.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

ACK, don't really know why it wasn't doing this already

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the libvir-list mailing list